Skip to content

http2,doc: minor fixes - #28044

Closed
mildsunrise wants to merge 1 commit into
nodejs:masterfrom
mildsunrise:feature/http2-fixes
Closed

mildsunrise wants to merge 1 commit into
nodejs:masterfrom
mildsunrise:feature/http2-fixes

Conversation

@mildsunrise

@mildsunrise mildsunrise commented Jun 3, 2019 •

Copy link
Copy Markdown
Contributor

Some small fixes on HTTP/2 and its documentation:

  • Fix server side example: start data flow when receiving a stream
    Add a note that, on server streams, it's not necessary to start data flow.

  • Set EOF flag if we have marked all data for sending: there's no need to wait until the queue is actually empty (and send a separate, empty DATA).

    (Note that, even with this change, an empty DATA frame will always be sent, because the streams layer waits until data has been flushed before queueing EOF)

  • Fix debug message

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues and PRs related to the http2 subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants