Repository navigation
Conversation
|
Review requested:
|
1b0baed to
2391fdf
Compare
|
CodeQL's C++ job still took over two hours in |
|
CodeQL aside, I don't think the small amount of timeouts is enough to justify deviating private from public. The more we deviate, the less we'll be able to notice if we break something on one repo or the other. |
|
That makes sense. I’ll leave the other jobs unchanged. The CodeQL C++ job still hasn’t completed successfully, and I’d like to wait for feedback from the Security WG, so I’ll move this PR back to draft for now. |
Use `build-mode: none` so that C++ is analyzed without building Node.js, which did not finish on either ubuntu-slim or ubuntu-latest. This also makes the existing `deps` exclusion apply to C++. Use ubuntu-latest, as the JavaScript analysis also hits the 15-minute limit of ubuntu-slim. Refs: nodejs/security-wg#1599 Refs: nodejs/security-wg#1453 Refs: nodejs#58254 Refs: nodejs#64972 Signed-off-by: inoway46 <inoueyuya416@gmail.com>
2391fdf to
ccf62a8
Compare
|
I've narrowed this down to the CodeQL workflow and switched it to |
The C++ CodeQL job hasn't completed in over a month, and the JavaScript one times out about half the time (example).
Moving to
ubuntu-latestalone wasn't enough for C++, since building Node.js under CodeQL takes hours there too. So this switches tobuild-mode: none, which also makes the existingdepsexclusion apply to C++.The downside is that C++ gets analyzed without build information, so it's less precise. I think that's still better than having no results.
With this change, all three languages finish in about five minutes on my fork.
Refs: nodejs/security-wg#1599