Repository navigation
gh-88496: IDLE - fix another test on macOS - #104075
Merged
Merged
Conversation
Needed for Catalina: test_sidebar add 'idletasks' and skip assert.
commented
May 2, 2023
Contributor
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
commented
May 2, 2023
Contributor
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
commented
May 2, 2023
|
GH-104076 is a backport of this pull request to the 3.11 branch. |
chrstphrchvz
reviewed
May 2, 2023
| sidebar.canvas.event_generate('<MouseWheel>', x=0, y=0, delta=delta) | ||
| yield | ||
| self.assertIsNone(text.dlineinfo(text.index(f'{last_lineno}.0'))) | ||
| if sys.platform != 'darwin': # .update_idletasks() does not work. |
Contributor
There was a problem hiding this comment.
Ordinarily I would ask if this test should continue to run on XQuartz if the problem is only on Aqua:
Suggested change
| if sys.platform != 'darwin': # .update_idletasks() does not work. | |
| if text._windowingsystem != 'aqua': # .update_idletasks() does not work. |
But this test was already failing on Aqua and XQuartz due to incorrectly negative delta. So this failure may have nothing to do with .update_idletasks(), and the test should not be skipped on Aqua or XQuartz. See #103820, #103821
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for Catalina: test_sidebar add 'idletasks' and skip assert.