Repository navigation
gh-132493: Support deferred annotations in Protocols - #132494
Merged
Merged
Conversation
sobolevn
reviewed
Apr 14, 2025
| class DeferredProto(Protocol): | ||
| x: DoesNotExist | ||
| self.assertEqual(get_protocol_members(DeferredProto), {"x"}) | ||
| self.assertEqual( |
Member
There was a problem hiding this comment.
Question: when should we test all formats and when just one is enough?
Member
Author
There was a problem hiding this comment.
I guess in this case Protocol is not doing anything very sophisticated with its annotations, so we can just run a basic test to make sure it works.
sobolevn
approved these changes
Apr 15, 2025
AlexWaygood
approved these changes
Apr 15, 2025
AlexWaygood
left a comment
Member
There was a problem hiding this comment.
I guess this might slow down protocol class creation a bit? Which might in turn slow down the import time of typing.py, since typing defines a lot of protocols... still, this feature seems worth it.
commented
Apr 15, 2025
Member
Author
|
I wonder if we could lazily create the protocol members list? But we can explore that separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.